On 03/20/2018 05:41 AM, Rafael J. Wysocki wrote: > On Fri, Mar 16, 2018 at 2:57 PM, Joao Martins <joao.m.martins@xxxxxxxxxx> wrote: >> On 03/15/2018 03:45 PM, Boris Ostrovsky wrote: >>> On 03/15/2018 10:22 AM, Joao Martins wrote: >>>> All uploaded PM data from non-dom0 CPUs takes the info from vCPU 0 and >>>> changing only the acpi_id. For processors which P-state coordination type >>>> is HW_ALL (0xFD) it is OK to upload bogus P-state dependency information >>>> (_PSD), because Xen will ignore any cpufreq domains created for past CPUs. >>>> >>>> Albeit for platforms which expose coordination types as SW_ANY or SW_ALL, >>>> this will have some unintended side effects. Effectively, it will look at >>>> the P-state domain existence and *if it already exists* it will skip the >>>> acpi-cpufreq initialization and thus inherit the policy from the first CPU >>>> in the cpufreq domain. This will finally lead to the original cpu not >>>> changing target freq to P0 other than the first in the domain. Which will >>>> make turbo boost not getting enabled (e.g. for 'performance' governor) for >>>> all cpus. >>>> >>>> This patch fixes that, by also evaluating _PSD when we enumerate all ACPI >>>> processors and thus always uploading the correct info to Xen. We export >>>> acpi_processor_get_psd() for that this purpose, but change signature >>>> to not assume an existent of acpi_processor given that ACPI isn't creating >>>> an acpi_processor for non-dom0 CPUs. >>>> >>>> Signed-off-by: Joao Martins <joao.m.martins@xxxxxxxxxx> >>> Reviewed-by: Boris Ostrovsky <boris.ostrovsky@xxxxxxxxxx> >>> >> Thanks! >> >> I suppose what's remaining is review (or ack) from ACPI folks on the interface >> changes made to acpi_processor_get_psd(). > There you go: > > Acked-by: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx> > > Do you want to route this via Xen? Sure, I'll queue it for 4.17 Thanks. -boris -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
