Hi Rafael,
On Mon, 26 Feb 2018 23:11:37 +0100, Rafael J. Wysocki wrote:
> On Mon, Feb 26, 2018 at 11:34 AM, Jean Delvare <jdelvare@xxxxxxx> wrote:
> > When ACPI debugging is disabled, I see warnings like this one:
> >
> > drivers/i2c/busses/i2c-scmi.c: In function "acpi_smbus_cmi_add_cap":
> > drivers/i2c/busses/i2c-scmi.c:328:39: warning: suggest braces around empty body in an "else" statement [-Wempty-body]
> > drivers/i2c/busses/i2c-scmi.c:338:12: warning: suggest braces around empty body in an "else" statement [-Wempty-body]
> >
> > It is caused by ACPI_DEBUG_PRINT (or other similar macros) resolving
> > to nothing. Make them resolve to the classic "do {} while (0)"
> > construct instead if the compiler likes that, or just {} if not, to
> > silent all such warnings.
>
> So first of all, acpi_smbus_cmi_add_cap() shouldn't really use
> ACPI_DEBUG_PRINT() and similar. They belong to ACPICA and their use
> should be limited to it.
OK, thanks for the information. I'll update the i2c-scmi driver to
no longer use ACPI_DEBUG_PRINT. There are a few other drivers using it as
well though (xo15-ebook and panasonic-laptop, as well as
xen-acpi-memhotplug - not sure if you consider that one as more
legitimate.)
> I know that they are used in the other parts of the ACPI subsystem,
> but they really should be replaced with the kernel's proper debug
> statements in there.
Ideally all these macros shouldn't be exposed to drivers which are not
supposed to use them. Could they be moved to a header file internal to
at least acpi?
--
Jean Delvare
SUSE L3 Support
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
