On Thu, Feb 15, 2018 at 2:52 PM, John Garry <john.garry@xxxxxxxxxx> wrote:
> On 15/02/2018 12:22, Andy Shevchenko wrote:
>> On Thu, Feb 15, 2018 at 1:19 PM, John Garry <john.garry@xxxxxxxxxx> wrote:
>>> +static const struct acpi_device_id indirect_io_hosts[] = {
>>> + {"HISI0191", 0}, /* HiSilicon LPC host */
>>> + {},
>>
>>
>> Just a nit.
>>
>
> I noticed that I have this in the LLDD also. I think that this may be a
> force of habit.
>> It seems lately this happens more often than usual, I mean a comma in
>> the terminator line.
>>
>> If we remove it. we terminate not only at runtime, but at compile
>> time, which is slightly better.
>
>
> I grepped for "{}," in the drivers folder and it gives many results (I do
> accept that some are not sentinels):
Yes, in old code it might be, but why to cargo-culting bad (okay, less
worth) practices?
>>grep -R "{}," * | tail
Btw, `git grep ...` is much faster.
> watchdog/gef_wdt.c: {},
> watchdog/asm9260_wdt.c: {},
> watchdog/bcm2835_wdt.c: {},
> watchdog/digicolor_wdt.c: {},
> watchdog/bcm7038_wdt.c: {},
> watchdog/ath79_wdt.c: {},
> watchdog/riowd.c: {},
> watchdog/sbsa_gwdt.c: {},
> watchdog/sbsa_gwdt.c: {},
> watchdog/bcm_kona_wdt.c: {},
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
