RE: [PATCH] ACPICA: Recognize the Windows 10 RS3 OSI string

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



> -----Original Message-----
> From: rjwysocki@xxxxxxxxx [mailto:rjwysocki@xxxxxxxxx] On Behalf Of Rafael J.
> Wysocki
> Sent: Wednesday, February 14, 2018 2:46 AM
> To: Limonciello, Mario <Mario_Limonciello@xxxxxxxx>
> Cc: ACPI Devel Maling List <linux-acpi@xxxxxxxxxxxxxxx>; Len Brown
> <lenb@xxxxxxxxxx>; Rafael J . Wysocki <rjw@xxxxxxxxxxxxx>; Mika Westerberg
> <mika.westerberg@xxxxxxxxxxxxxxx>
> Subject: Re: [PATCH] ACPICA: Recognize the Windows 10 RS3 OSI string
> 
> On Tue, Feb 13, 2018 at 7:00 PM, Mario Limonciello
> <mario.limonciello@xxxxxxxx> wrote:
> > Dell uses this string to activate Thunderbolt native mode on supported
> > machines.
> >
> > Signed-off-by: Mario Limonciello <mario.limonciello@xxxxxxxx>
> > ---
> > Thunderbolt Native mode requires other patches to be applied otherwise
> > this patch will cause problems.

I should have been clearer  - problems with thunderbolt driver in Linux.

If you apply this patch without the rest of Mika's series there will be problems
with Thunderbolt native mode in Linux.

The patches you already reviewed in
>    https://marc.info/?l=linux-acpi&m=151853954129169&w=2

Are the more important ones, but a few of the fixes that came in the second
series help with some of the corner cases (for example cold boot ICM timeout).

Mika might have a few more comments to add here from the testing he did
to make those patches.

> >
> > This patch should only be applied with:
> > 1) Acpiphp platches from
> >    https://marc.info/?l=linux-acpi&m=151853954129169&w=2
> > and
> >
> > 2) Thunderbolt patches from
> >    https://lkml.org/lkml/2018/2/13/685
> 
> Thanks for these pointers, they help a lot.
> 
> > This has also been submited into ACPICA:
> > https://github.com/acpica/acpica/pull/359
> 
> Due to the dependencies outside of upstream ACPICA, I don't think that
> this patch is suitable for upstream ACPICA at all.

Actually ACPICA did merge it already:
https://github.com/acpica/acpica/commit/24f7791789c49ec02eb024106c85d23322be5672

> 
> >
> >  drivers/acpi/acpica/utosi.c | 1 +
> >  include/acpi/actypes.h      | 1 +
> >  2 files changed, 2 insertions(+)
> >
> > diff --git a/drivers/acpi/acpica/utosi.c b/drivers/acpi/acpica/utosi.c
> > index f6b8dd2..aed77c3 100644
> > --- a/drivers/acpi/acpica/utosi.c
> > +++ b/drivers/acpi/acpica/utosi.c
> > @@ -103,6 +103,7 @@ static struct acpi_interface_info
> acpi_default_supported_interfaces[] = {
> >         {"Windows 2015", NULL, 0, ACPI_OSI_WIN_10},     /* Windows 10 - Added
> 03/2015 */
> >         {"Windows 2016", NULL, 0, ACPI_OSI_WIN_10_RS1}, /* Windows 10 version
> 1607 - Added 12/2017 */
> >         {"Windows 2017", NULL, 0, ACPI_OSI_WIN_10_RS2}, /* Windows 10 version
> 1703 - Added 12/2017 */
> > +       {"Windows 2017.2", NULL, 0, ACPI_OSI_WIN_10_RS3}, /* Windows 10
> version 1709 - Added 02/2018 */
> >
> >         /* Feature Group Strings */
> >
> > diff --git a/include/acpi/actypes.h b/include/acpi/actypes.h
> > index 31f1be7..3f829cc 100644
> > --- a/include/acpi/actypes.h
> > +++ b/include/acpi/actypes.h
> > @@ -1303,6 +1303,7 @@ typedef enum {
> >  #define ACPI_OSI_WIN_10                 0x0D
> >  #define ACPI_OSI_WIN_10_RS1             0x0E
> >  #define ACPI_OSI_WIN_10_RS2             0x0F
> > +#define ACPI_OSI_WIN_10_RS3             0x10
> >
> >  /* Definitions of getopt */
> >
> > --
��.n��������+%������w��{.n�����{�����ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f




[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux