On Wed, Feb 7, 2018 at 3:56 PM, Andy Shevchenko
<andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
> Instead of playing tricks with last invalid entry,
> return simple -ENODATA error code cast to pointer.
>
> It would be good for future in case caller passes NULL pointer for
> ID table. Moreover, caller can check the code to be sure what happened
> inside callee.
>
> Fixes: 2b9c698efa58 ("ACPI / scan: Take the PRP0001 position in the list of IDs into account")
I still don't think the Fixes: tag here is valid (the code works as is
AFAICS), but I could drop it when applying the patch just fine. :-)
That said, see below.
> Cc: Sinan Kaya <okaya@xxxxxxxxxxxxxx>
> Cc: Sakari Ailus <sakari.ailus@xxxxxxxxxxxxxxx>
> Cc: Vinod Koul <vinod.koul@xxxxxxxxx>
> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
> ---
> drivers/acpi/bus.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
> diff --git a/drivers/acpi/bus.c b/drivers/acpi/bus.c
> index 58239abb0a72..761286e50067 100644
> --- a/drivers/acpi/bus.c
> +++ b/drivers/acpi/bus.c
> @@ -769,7 +769,7 @@ static const struct acpi_device_id *__acpi_match_device(
> */
> if (!strcmp(ACPI_DT_NAMESPACE_HID, hwid->id)
> && acpi_of_match_device(device, of_ids))
> - return id;
> + return ERR_PTR(-ENODATA);
Doesn't the comment above need to be updated?
Also the return value here means "success", so why is an error the right choice?
> }
> return NULL;
> }
> --
Overall, this really looks like a preparation for a future patch, so
why not just say that straight away in the changelog?
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
