RE: [PATCH 1/2] ACPICA: acpi_ds_resolve_package_element: Use proper status when logging exception

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



We are working on this file right now, thanks.
Bob


> -----Original Message-----
> From: Hans de Goede [mailto:hdegoede@xxxxxxxxxx]
> Sent: Friday, January 12, 2018 3:37 AM
> To: Len Brown <lenb@xxxxxxxxxx>; Moore, Robert <robert.moore@xxxxxxxxx>;
> Zheng, Lv <lv.zheng@xxxxxxxxx>
> Cc: Hans de Goede <hdegoede@xxxxxxxxxx>; linux-acpi@xxxxxxxxxxxxxxx;
> devel@xxxxxxxxxx
> Subject: [PATCH 1/2] ACPICA: acpi_ds_resolve_package_element: Use proper
> status when logging exception
> 
> Do not override the status which causes us to call acpi_exception with
> the status returned by the acpi_ns_externalize_name call we do to get a
> name to log.
> 
> Related: https://bugzilla.kernel.org/show_bug.cgi?id=198167
> Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx>
> ---
>  drivers/acpi/acpica/dspkginit.c | 6 +++---
>  1 file changed, 3 insertions(+), 3 deletions(-)
> 
> diff --git a/drivers/acpi/acpica/dspkginit.c
> b/drivers/acpi/acpica/dspkginit.c index 6d487edfe2de..cddbbed2f344
> 100644
> --- a/drivers/acpi/acpica/dspkginit.c
> +++ b/drivers/acpi/acpica/dspkginit.c
> @@ -372,9 +372,9 @@ acpi_ds_resolve_package_element(union
> acpi_operand_object **element_ptr)
>  				ACPI_NS_SEARCH_PARENT | ACPI_NS_DONT_OPEN_SCOPE,
>  				NULL, &resolved_node);
>  	if (ACPI_FAILURE(status)) {
> -		status = acpi_ns_externalize_name(ACPI_UINT32_MAX,
> -						  (char *)element->reference.
> -						  aml, NULL, &external_path);
> +		acpi_ns_externalize_name(ACPI_UINT32_MAX,
> +					 (char *)element->reference.aml, NULL,
> +					 &external_path);
> 
>  		ACPI_EXCEPTION((AE_INFO, status,
>  				"Could not find/resolve named package element: %s",
> --
> 2.14.3

--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux