Hi Andrew, 2018-01-03 13:47 GMT+01:00 Andrew Lunn <andrew@xxxxxxx>: >> I already agreed with 'reg' being awkward in the later emails. >> Wouldn't _ADR be more appropriate to specify PHY address on MDIO bus? > > Also, how do you specify which MDIO bus the PHY is on. To fully > specify a PHY, you need both bits of information. > > In DT, the phy-handle phandle can point to any PHY anywhere in the > system. This is particularly important when a Ethernet device has two > MDIO busses. > For now, my local MDIO bus description is pretty DT-like, i.e. master bus with children PHYs: Device (MDIO) { Name (_HID, "MRVL0100") // _HID: Hardware ID Name (_UID, 0x00) // _UID: Unique ID Name (_CRS, ResourceTemplate () { Memory32Fixed (ReadWrite, 0xf212a200, // Address Base 0x00000010, // Address Length ) }) Device (GPHY) { Name (_ADR, 0x0) } } Device (XSMI) { Name (_HID, "MRVL0101") // _HID: Hardware ID Name (_UID, 0x00) // _UID: Unique ID Name (_CRS, ResourceTemplate () { Memory32Fixed (ReadWrite, 0xf212a600, // Address Base 0x00000010, // Address Length ) }) Device (PHY0) { Name (_ADR, 0x0) Name (_CID, "ethernet-phy-ieee802.3-c45") } Device (PHY8) { Name (_ADR, 0x8) Name (_CID, "ethernet-phy-ieee802.3-c45") } } Which is referenced in the port's node: Package () { "phy", Package (){\_SB.XSMI.PHY0}}, I'm studying an alternatives with graphs, as suggested by Tomasz Nowicki, but to me above is pretty natural and not complicated. Best regards, Marcin -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html