On Thu, Dec 14, 2017 at 08:08:08AM -0600, Timur Tabi wrote: > On 12/14/17 4:30 AM, Lorenzo Pieralisi wrote: > >>I didn't want to put any ACPI code in amba-pl011.c, so putting it in spcr.c > >>made the most sense. I agree the global variable is ugly. If you have a > >>better idea, I'm all ears. > > >I told you my idea. It could have been made easier by reusing the > >ACPI_DECLARE_PROBE_ENTRY() mechanism. > > Sorry, I don't mean to be difficult, but when did you tell *me* this idea of > yours? I don't see any email from you to me that mentions I said that IMO it would have been better if the quirk was managed in amba-pl011.c - you had your reasons not to do it, end of the story. > ACPI_DECLARE_PROBE_ENTRY(). I've never even heard of that macro before. > Please note that I'm not the original author of this code. It is what it is, let's move on, we will keep this in mind if a similar quirk is required. Thanks, Lorenzo -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
