> -----Original Message----- > From: rjwysocki@xxxxxxxxx [mailto:rjwysocki@xxxxxxxxx] On Behalf Of Rafael > J. Wysocki > Sent: Friday, December 8, 2017 9:06 AM > To: Vasyl Gomonovych <gomonovych@xxxxxxxxx> > Cc: Moore, Robert <robert.moore@xxxxxxxxx>; Zheng, Lv > <lv.zheng@xxxxxxxxx>; Wysocki, Rafael J <rafael.j.wysocki@xxxxxxxxx>; Len > Brown <lenb@xxxxxxxxxx>; ACPI Devel Maling List <linux-acpi@xxxxxxxxxxxxxxx>; > devel@xxxxxxxxxx; Linux Kernel Mailing List <linux-kernel@xxxxxxxxxxxxxxx>; > Schmauss, Erik <erik.schmauss@xxxxxxxxx> > Subject: Re: [PATCH] ACPICA: Fix indentation > > On Fri, Dec 8, 2017 at 5:29 PM, Vasyl Gomonovych <gomonovych@xxxxxxxxx> > wrote: > > This patch avoids that smatch reports the following: > > drivers/acpi/acpica/exdump.c:623 acpi_ex_dump_operand() warn: > > inconsistent indenting > > > > Signed-off-by: Vasyl Gomonovych <gomonovych@xxxxxxxxx> > > This is ACPICA code, so changes like this should go in via the upstream. > Hi, > Erik may want to pick this up, however. > Thanks for pointing this out. I found solution to fix the indentation issue. It will be in the next release. Erik > > --- > > drivers/acpi/acpica/exdump.c | 4 ++-- > > 1 file changed, 2 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/acpi/acpica/exdump.c > > b/drivers/acpi/acpica/exdump.c index 83398dc..f43d3d7 100644 > > --- a/drivers/acpi/acpica/exdump.c > > +++ b/drivers/acpi/acpica/exdump.c > > @@ -619,8 +619,8 @@ void acpi_ex_dump_operand(union > > acpi_operand_object *obj_desc, u32 depth) > > > > ACPI_FUNCTION_NAME(ex_dump_operand) > > > > - /* Check if debug output enabled */ > > - if (!ACPI_IS_DEBUG_ENABLED(ACPI_LV_EXEC, _COMPONENT)) { > > + /* Check if debug output enabled */ > > + if (!ACPI_IS_DEBUG_ENABLED(ACPI_LV_EXEC, _COMPONENT)) { > > return; > > } > > > > -- ��.n��������+%������w��{.n�����{�����ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f