On Wed, 2017-12-13 at 09:56 +0100, Hans de Goede wrote: > Hi, > > On 13-12-17 01:01, Rafael J. Wysocki wrote: > > On Monday, September 25, 2017 9:23:52 PM CET Johannes Stezenbach > > wrote: > > > d31fd43c0f9a "clk: x86: Do not gate clocks enabled by the > > > firmware" > > > exposed an issue on Asus E200HA where BIOS enables unused > > > Atom PMC clocks which prevent the system from entering S0ix. > > > Add a quirk to disable these clocks on E200HA. > > > > > > Signed-off-by: Johannes Stezenbach <js@xxxxxxxxx> > > > > Mika, Andy, Hans, any comments here? I remember discussing those in bugzilla, though I agree with Hans, it looks hackish still. I'm not sure on the other hand we can solve this properly in a meantime. I also have some style related comments, but they are minor. I can go through better review after we settle down the way we would like to fix the issue. > This seems like it is papering over an issue in the > d31fd43c0f9a "clk: x86: Do not gate clocks enabled by the firmware" > patch to me. That patch seems like a somewhat hackish fix to > me, it would be better to figure out which device needs the clock > in question and fix the device's driver... My understanding of S0ix prerequisites is all devices in question *must* have drivers loaded and drivers *must* have implemented runtime PM. (Since I don't know if it's guaranteed by firmware that devices are left in D3 if they are not used. Besides that from the SATA case looks like some BIOS [hardware?] issue with power gating) -- Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> Intel Finland Oy -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
