On Thu, 2017-11-30 at 17:55 -0800, Dan Williams wrote: > Integration testing with a BIOS that generates injected health event > notifications fails to communicate those events to userspace. The nfit > driver neglects to link the ACPI DIMM device with the necessary driver > data so acpi_nvdimm_notify() fails this lookup: > > nfit_mem = dev_get_drvdata(dev); > if (nfit_mem && nfit_mem->flags_attr) > sysfs_notify_dirent(nfit_mem->flags_attr); > > Add the necessary linkage when installing the notification handler and > clean it up when the nfit driver instance is torn down. > > Cc: <stable@xxxxxxxxxxxxxxx> > Cc: Toshi Kani <toshi.kani@xxxxxxx> > Cc: Vishal Verma <vishal.l.verma@xxxxxxxxx> > Fixes: ba9c8dd3c222 ("acpi, nfit: add dimm device notification support") > Reported-by: Daniel Osawa <daniel.k.osawa@xxxxxxxxx> > Signed-off-by: Dan Williams <dan.j.williams@xxxxxxxxx> The fix looks good. Sorry it appears that I only tested ACPI notification, not sysfs event, for the original change. Reviewed-by: Toshi Kani <toshi.kani@xxxxxxx> Thanks! -Toshi��.n��������+%������w��{.n�����{�����ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f