> -----Original Message----- > From: Bjorn Helgaas [mailto:helgaas@xxxxxxxxxx] > Sent: 07 November 2017 00:23 > To: Gabriele Paoloni > Cc: catalin.marinas@xxxxxxx; will.deacon@xxxxxxx; robh+dt@xxxxxxxxxx; > frowand.list@xxxxxxxxx; bhelgaas@xxxxxxxxxx; rafael@xxxxxxxxxx; > arnd@xxxxxxxx; linux-arm-kernel@xxxxxxxxxxxxxxxxxxx; > lorenzo.pieralisi@xxxxxxx; mark.rutland@xxxxxxx; brian.starkey@xxxxxxx; > olof@xxxxxxxxx; benh@xxxxxxxxxxxxxxxxxxx; linux-kernel@xxxxxxxxxxxxxxx; > linux-acpi@xxxxxxxxxxxxxxx; Linuxarm; linux-pci@xxxxxxxxxxxxxxx; > minyard@xxxxxxx; John Garry; xuwei (O) > Subject: Re: [PATCH v10 2/9] PCI: remove unused __weak attribute in > pci_register_io_range() > > > PCI: remove unused __weak attribute in pci_register_io_range() > > Please capitalize to follow drivers/pci convention, e.g., > > PCI: Remove __weak attribute from pci_register_io_range() > > (Also do the same for the other PCI patches.) Agreed, many thanks Gab > > On Fri, Oct 27, 2017 at 05:11:20PM +0100, Gabriele Paoloni wrote: > > From: gabriele paoloni <gabriele.paoloni@xxxxxxxxxx> > > > > Currently pci_register_io_range() has only one definition; > > therefore there is no use of the __weak attribute. > > > > Signed-off-by: Gabriele Paoloni <gabriele.paoloni@xxxxxxxxxx> > > Acked-by: Bjorn Helgaas <helgaas@xxxxxxxxxx> > > --- > > drivers/pci/pci.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > > > > diff --git a/drivers/pci/pci.c b/drivers/pci/pci.c > > index af0cc34..eee967c 100644 > > --- a/drivers/pci/pci.c > > +++ b/drivers/pci/pci.c > > @@ -3270,7 +3270,7 @@ static DEFINE_SPINLOCK(io_range_lock); > > * Record the PCI IO range (expressed as CPU physical address + > size). > > * Return a negative value if an error has occured, zero otherwise > > */ > > -int __weak pci_register_io_range(phys_addr_t addr, resource_size_t > size) > > +int pci_register_io_range(phys_addr_t addr, resource_size_t size) > > { > > int err = 0; > > > > -- > > 2.7.4 > > > > > > -- > > To unsubscribe from this list: send the line "unsubscribe linux-acpi" > in > > the body of a message to majordomo@xxxxxxxxxxxxxxx > > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
