On Wed, Sep 27, 2017 at 08:22:23PM +0530, Kamlakant Patel wrote: > + priv->len_recv = (msg->flags & I2C_M_RECV_LEN); You don't need parens here. > + len = priv->len_recv ? XLP9XX_I2C_FIFO_SIZE : msg->len; > + priv->client_pec = (msg->flags & I2C_CLIENT_PEC); Ditto. Otherwise looks good to me, Reviewed-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx> -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html