On Mon, 04 Sep 2017 15:37:32 +0200, Lee Jones wrote: > > > +static struct mfd_cell dc_ti_dev[] = { > > + { > > + .name = "dc_ti_pwrbtn", > > + .num_resources = ARRAY_SIZE(power_button_resources), > > + .resources = power_button_resources, > > + }, > > + { > > Place these on the same line. Does this and ... > > + }, > > + { > > + .name = "dc_ti_region", > > + }, > > This should be a one line entry: > > { .name = "dc_ti_region" }, .... this match together? The result would be like: static struct mfd_cell dc_ti_dev[] = { { .name = "dc_ti_pwrbtn", .num_resources = ARRAY_SIZE(power_button_resources), .resources = power_button_resources, }, { .name = "chtdc_ti_adc", .num_resources = ARRAY_SIZE(adc_resources), ..... }, { .name = "chtdc_ti_region", }, }; which I find a bit inconsistent. thanks, Takashi -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html