On Tue, Aug 22, 2017 at 7:57 PM, Yang, Hyungwoo <hyungwoo.yang@xxxxxxxxx> wrote: > > Hi Rafael, > > The problem was found while testing my code and the code is working fine with this patch. OK, thanks for the confirmation! I will apply it here, but Bob and Lv, please make the equivalent change upstream. Thanks, Rafael > -----Original Message----- >> From: Rafael J. Wysocki [mailto:rjw@xxxxxxxxxxxxx] >> Sent: Monday, August 21, 2017 4:42 PM >> To: Ailus, Sakari <sakari.ailus@xxxxxxxxx> >> Cc: Moore, Robert <robert.moore@xxxxxxxxx>; ACPI Devel Maling List <linux-acpi@xxxxxxxxxxxxxxx>; Yang, Hyungwoo <hyungwoo.yang@xxxxxxxxx>; Zheng, Lv <lv.zheng@xxxxxxxxx> >> Subject: Re: ACPI _DSD sub-node parsing broken in linux-next? >> >> On Monday, August 21, 2017 2:56:44 PM CEST Sakari Ailus wrote: >> > Hi Bob, Rafael, others, >> > >> > There seem to be a problem with this patch recently merged to linux-pm >> > tree for v4.13: >> > >> > <URL:https://git.linuxtv.org/media_tree.git/patch/drivers/acpi/acpica/ >> > nsxfeval.c?id=2d2a954375a0405fc721928f0dcc5ad1418996bc> >> > >> > Some callers and acpi_nonsubnode_data_ok() in particular call >> > acpi_evaluate_object_typed() with NULL pathname argument which I >> > understand was fine before that patch. After that patch, pathname is >> > mandatory. >> > >> > >> >> Does the patch below help (untested here)? >> >> --- >> drivers/acpi/acpica/nsxfeval.c | 10 +++++++--- >> 1 file changed, 7 insertions(+), 3 deletions(-) >> >> Index: linux-pm/drivers/acpi/acpica/nsxfeval.c >> =================================================================== >> --- linux-pm.orig/drivers/acpi/acpica/nsxfeval.c >> +++ linux-pm/drivers/acpi/acpica/nsxfeval.c >> @@ -100,9 +100,13 @@ acpi_evaluate_object_typed(acpi_handle h >> free_buffer_on_error = TRUE; >> } >> >> - status = acpi_get_handle(handle, pathname, &target_handle); >> - if (ACPI_FAILURE(status)) { >> - return_ACPI_STATUS(status); >> + if (pathname) { >> + status = acpi_get_handle(handle, pathname, &target_handle); >> + if (ACPI_FAILURE(status)) { >> + return_ACPI_STATUS(status); >> + } >> + } else { >> + target_handle = handle; >> } >> >> full_pathname = acpi_ns_get_external_pathname(target_handle); >> >> > -- > To unsubscribe from this list: send the line "unsubscribe linux-acpi" in > the body of a message to majordomo@xxxxxxxxxxxxxxx > More majordomo info at http://vger.kernel.org/majordomo-info.html -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
