On Thursday, August 10, 2017 3:48:58 AM CEST Zheng, Lv wrote: > Hi, Rafael > > > From: Rafael J. Wysocki [mailto:rjw@xxxxxxxxxxxxx] > > Subject: [PATCH 1/3] ACPICA: Dispatch active GPEs at init time > > > > From: Rafael J. Wysocki <rafael.j.wysocki@xxxxxxxxx> > > > > In some cases GPEs are already active when they are enabled by > > acpi_ev_initialize_gpe_block() and whatever happens next may depend > > on the result of handling the events signaled by them, so the > > events should not be discarded (which is what happens currently) and > > they should be handled as soon as reasonably possible. > > > > For this reason, modify acpi_ev_initialize_gpe_block() to > > dispatch GPEs with the status flag set in-band right after > > enabling them. > > In fact, what we need seems to be invoking acpi_ev_gpe_dispatch() > right after enabling an GPE. So there are 2 conditions related: > 1. GPE is enabled for the first time. > 2. GPE is initialized. > > And we need to make sure that before acpi_update_all_gpes() is invoked, > all GPE EN bits are actually disabled. But we don't do it today, do we? And still calling _dispatch() should not be incorrect even if the GPE has been enabled already at this point. Worst case it just will queue up the execution of _Lxx/_Exx which may or may not do anything useful. And BTW this is all done under acpi_gbl_gpe_lock so acpi_ev_gpe_detect() will block on it if run concurrently and we've checked the status, so we know that the GPE *should* be dispatched, so I sort of fail to see the problem. Thanks, Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
