Re: [PATCH] ACPI / watchdog: Fix init failure with overlapping register regions

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Tue, Jul 25, 2017 at 12:37:31PM +0300, Mika Westerberg wrote:
> I wonder why we need to do this?
> 
> +                           if (res.start < rentry->res->start)
> +                                   rentry->res->start = res.start;
> +                           if (res.end > rentry->res->end)
> +                                   rentry->res->end = res.end;
> 
> IIRC we don't use rentry for anything else when we go out of the loop.
> Tuning those limits seems unnecessary.

OK, Ryan pointed out that the later code then uses the adjusted rentry
so this is indeed needed.

Acked-by: Mika Westerberg <mika.westerberg@xxxxxxxxxxxxxxx>
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux