On Tue, 2017-07-18 at 18:43 +0200, Borislav Petkov wrote:
> On Tue, Jul 18, 2017 at 03:48:54PM +0000, Kani, Toshimitsu wrote:
> > This patch defines 'struct acpi_oemlist' in "include/linux/acpi.h"
> > as a
>
> I see that.
>
> > common structure, and replaces this specific 'struct
> > acpi_blacklist'.
>
> And what makes acpi_oemlist "common" and acpi_blacklist "specific"?
>
> So let me save you some time - "oemlist" is more specific than
> "blacklist" and I can imagine a blacklist item not always being
> oem-specific.
>
> What I'm hinting at is, don't change that name. acpi_blacklist is
> just fine.
Well, a list does not need to be a black-list. It can be a white-list
or anything that matters. The caller defines the usage of a list. So,
I tried to avoid putting any usage to the structure name.
> > Agreed. Will change to a shorter name like below.
> >
> > enum acpi_oemlist_pred predicate;
>
> enum acpi_predicate pred;
>
> is even better.
Sounds good.
Thanks,
-Toshi
��.n��������+%������w��{.n�����{�����ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f
