Re: [PATCH v2 2/5] ACPI / boot: Correct address space of __acpi_map_table()

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On 2017/7/18 17:23, Andy Shevchenko wrote:
> On Tue, 2017-07-18 at 11:03 +0200, Geert Uytterhoeven wrote:
>> Hi Andy,
>>
>> On Mon, Jul 17, 2017 at 12:24 PM, Andy Shevchenko
>> <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote:
>>> Sparse complains about wrong address space used in
>>> __acpi_map_table()
>>> and in __acpi_unmap_table().
>>>
>>> arch/x86/kernel/acpi/boot.c:127:29: warning: incorrect type in
>>> return expression (different address spaces)
>>> arch/x86/kernel/acpi/boot.c:127:29:    expected char *
>>> arch/x86/kernel/acpi/boot.c:127:29:    got void [noderef] <asn:2>*
>>> arch/x86/kernel/acpi/boot.c:135:23: warning: incorrect type in
>>> argument 1 (different address spaces)
>>> arch/x86/kernel/acpi/boot.c:135:23:    expected void [noderef]
>>> <asn:2>*addr
>>> arch/x86/kernel/acpi/boot.c:135:23:    got char *map
>>>
>>> Correct address space to be in align of type of returned and passed
>>> parameter.
>>>
>>> Signed-off-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
>>> ---
>>>  arch/arm64/kernel/acpi.c    | 4 ++--
>> Thanks for the update!
>> I can confirm this fixes the arm64 build for me.
> Thanks to you and thanks to kbuild bot to check for ia64!
>
> I will send v3 soon with fixed this part and extended patch 5.

Ah, sorry, there are some delays when I got this email...,
forget about my comments on patch 5.

Thanks
Hanjun


--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux