On 05/24/2017 12:27 PM, Kees Cook wrote:
> On Wed, May 24, 2017 at 8:30 AM, Prarit Bhargava <prarit@xxxxxxxxxx> wrote:
>> Sent a few weeks back ... no reply.
>
> I've added Huang Ying to CC, as the original author of this code. It
> looks fine to me, FWIW.
>
> -Kees
ping -- Huang? Rafael?
P.
>
>>
>> P.
>>
>> ---8<---
>>
>> The word "Error" is used by many QA groups and users as a keyword to
>> indicate that there is a critical failure during system bootup. The ESRT
>> code would interact better with these scripts if the word "Error" was
>> dropped from non-error messages. Other ACPI features only use the acronym
>> for initialization and disable messages so the ESRT code should do the
>> same.
>>
>> Remove "Error Record Serialization Table" and replace it with "ACPI ESRT"
>> in the messages.
>>
>> Signed-off-by: Prarit Bhargava <prarit@xxxxxxxxxx>
>> Cc: Kees Cook <keescook@xxxxxxxxxxxx>
>> Cc: Anton Vorontsov <anton@xxxxxxxxxx>
>> Cc: Colin Cross <ccross@xxxxxxxxxxx>
>> Cc: Tony Luck <tony.luck@xxxxxxxxx>
>> Cc: "Rafael J. Wysocki" <rjw@xxxxxxxxxxxxx>
>> Cc: Len Brown <lenb@xxxxxxxxxx>
>
> This is fine by me.
>
>> ---
>> drivers/acpi/apei/erst.c | 6 ++----
>> 1 file changed, 2 insertions(+), 4 deletions(-)
>>
>> diff --git a/drivers/acpi/apei/erst.c b/drivers/acpi/apei/erst.c
>> index ec4f507b524f..a796b9d91e20 100644
>> --- a/drivers/acpi/apei/erst.c
>> +++ b/drivers/acpi/apei/erst.c
>> @@ -1129,8 +1129,7 @@ static int __init erst_init(void)
>> goto err;
>>
>> if (erst_disable) {
>> - pr_info(
>> - "Error Record Serialization Table (ERST) support is disabled.\n");
>> + pr_info("ACPI ERST support is disabled.\n");
>> goto err;
>> }
>>
>> @@ -1187,8 +1186,7 @@ static int __init erst_init(void)
>> if (!erst_erange.vaddr)
>> goto err_release_erange;
>>
>> - pr_info(
>> - "Error Record Serialization Table (ERST) support is initialized.\n");
>> + pr_info("ACPI ERST support is initialized.\n");
>>
>> buf = kmalloc(erst_erange.size, GFP_KERNEL);
>> spin_lock_init(&erst_info.buf_lock);
>> --
>> 1.7.9.3
>>
>
>
>
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
