Re: [PATCH v1] i2c: core: Protect acpi_match_device() against NULL

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Mon, 2017-07-10 at 20:21 +0200, Wolfram Sang wrote:
> On Sun, Jul 09, 2017 at 04:18:19PM +0300, Andy Shevchenko wrote:
> > On Sun, 2017-07-09 at 16:16 +0300, Andy Shevchenko wrote:
> > > The commit 09b3b246acba
> > > 	("i2c: core: Allow empty id_table in ACPI case as well")
> > > brought an additional check for ACPI match table entry, though
> > > missed
> > > NULL check for table itself.
> > > 
> > > Do it here by introducing a helper i2c_acpi_match_device().
> > > 
> > > Note, we rename some static function in i2c-core-acpi.c to
> > > distinguish
> > > with public API.
> > > 
> > 
> > Wolfram, feel free to squash it into the original commit if it looks
> > better. 
> 
> I didn't want to send Linus a branch which too many last minute fixes.
> That's why I dropped the original patch and would like to ask you to
> resend a combined patch after rc1. If it is a bugfix, we will have no
> problems getting it into v4.13 but it seems a bit more testing is
> needed.

Okay, let's do this way.

I may also try to convert existing users (some coccinelle script I
suppose).

-- 
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux