On Wednesday, June 21, 2017 11:15:43 AM Darren Hart wrote: > On Fri, Jun 16, 2017 at 06:40:52AM +0200, Michał Kępień wrote: > > All ACPI device notify callbacks are invoked using acpi_os_execute(), > > which causes the supplied callback to be queued to a static workqueue > > which always executes on CPU 0. This means that there is no possibility > > for any ACPI device notify callback to be concurrently executed on > > multiple CPUs, which in the case of fujitsu-laptop means that using a > > locked kfifo for handling hotkeys is redundant: as hotkey scancodes are > > only pushed and popped from within acpi_fujitsu_laptop_notify(), no risk > > of concurrent pushing and popping exists. > > Was the kfifo causing a problem currently or for the migration to separate > modules? Is this purely a simplification? > > Rafael, the above rationale appears sound to me. Do you have any concerns? I actually do. While this is the case today, making the driver code depend on it in a hard way sort of makes it difficult to change in the future if need be. Thanks, Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
