On Thu, Jun 22, 2017 at 01:04:22PM +0300, Mika Westerberg wrote:
> On Thu, Jun 22, 2017 at 11:54:39AM +0200, Lukas Wunner wrote:
> > On Thu, Jun 22, 2017 at 11:06:55AM +0300, Mika Westerberg wrote:
> > > On Wed, Jun 21, 2017 at 08:05:53PM +0200, Lukas Wunner wrote:
> > > > + props = acpi_evaluate_dsm_typed(adev->handle, apple_prp_uuid, 1, 0,
> > > > + NULL, ACPI_TYPE_BUFFER);
> > > > + if (!props || !props->buffer.length)
> > > > + goto out_free;
> > > > +
> > > > + version = props->buffer.pointer[0];
> > > > + ACPI_FREE(props);
> > > > + if (version != 3) {
> > > > + acpi_handle_err(adev->handle,
> > > > + "unsupported properties version %u\n", version);
> > >
> > > I don't think this is error. More like debug if anything.
> >
> > It would be good to be able to google for this message to detect if there
> > are ever Macs out there which return something different than "3" to this
> > _DSM call. How about KERN_WARN or KERN_INFO?
>
> Well, this is something the user might see and then gets confused on the
> grounds: is my machine somehow broken?
And indeed it might be: Conceivably, Apple may change the format of the
properties and then once again the SPI slave won't be able to initialize.
In that case it seems beneficial to provide a clue as to the cause in dmesg.
Thanks,
Lukas
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
