Hi Linus, > Subject: Re: [PATCH v1 2/3] gpio: Add support for TPS68470 GPIOs > > +static inline struct tps68470_gpio_data *to_gpio_data(struct > > +gpio_chip *gpiochp) { > > + return container_of(gpiochp, struct tps68470_gpio_data, gc); } > > Please use the data pointe inside gpio_chip. > My bad. I completely missed the following line. Will fix it v3. > struct tps68470_gpio_data *foo = gpiochip_get_data(gc); > ��.n��������+%������w��{.n�����{�����ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f