Hi Hans, > -----Original Message----- > From: Hans de Goede [mailto:hdegoede@xxxxxxxxxx] > Sent: Tuesday, June 06, 2017 8:22 AM > To: Andy Shevchenko <andy.shevchenko@xxxxxxxxx>; Mani, Rajmohan > <rajmohan.mani@xxxxxxxxx> > Cc: linux-kernel@xxxxxxxxxxxxxxx; linux-gpio@xxxxxxxxxxxxxxx; linux- > acpi@xxxxxxxxxxxxxxx; Lee Jones <lee.jones@xxxxxxxxxx>; Linus Walleij > <linus.walleij@xxxxxxxxxx>; Alexandre Courbot <gnurou@xxxxxxxxx>; Rafael J. > Wysocki <rjw@xxxxxxxxxxxxx>; Len Brown <lenb@xxxxxxxxxx> > Subject: Re: [PATCH v1 3/3] ACPI / PMIC: Add TI PMIC TPS68470 operation > region driver > > Hi, > > On 06/06/2017 04:23 PM, Andy Shevchenko wrote: > > +Cc Hans (that's why didn't delete anything from original mail, just > > adding my comments). > > > > Hans, if you have few minutes it would be appreciated to glance on the > > below for some issues if any since you did pass quite a good quest > > with other PMIC drivers. > > I've gone over this driver, nothing stands out in a bad way to me, IOW this > seems like a normal PMIC OpRegion handler to me. > Thanks for the reviews and time. ��.n��������+%������w��{.n�����{�����ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f