On Fri, Jun 09, 2017 at 01:18:25AM +0000, Zheng, Lv wrote: > > Subject: [PATCH] ACPICA: Remove unnecessary call to debugger > > > > This is a port of https://github.com/acpica/acpica/commit/eaa455ac by > > Robert Moore to the kernel: > > > > > This call was simply wrong, and resulted in a -1 index into the operand > > > stack. > > > > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=120351 > > Signed-off-by: Adam Borowski <kilobyte@xxxxxxxxxx> > > I think my first fix also worked and your test on bug 120351 was wrong. > I just added comment a moment ago. > > However I just pushed the removal of the wrong debugging statement fix to the upstream. > It's really redundant, you need to enable the log and check them. > > The patch has already been sent here: > https://patchwork.kernel.org/patch/9765837/ > So you don't have to send it again. Date: June 5, and it's not even in next-20170608 yet, so I obviously didn't see you applying the fix (it seemed stalled since Apr 4). If it's already on the way, that's good. However, it is not redundant: without this removal, I see the UBSAN error (at least in current mainline). Whether an alternate fix would be enough is another question. You guys know more about the issue, all I know is whether I see warnings spewed into my dmesg :) Meow! -- ⢀⣴⠾⠻⢶⣦⠀ A tit a day keeps the vet away. ⣾⠁⢰⠒⠀⣿⡁ ⢿⡄⠘⠷⠚⠋⠀ (Rejoice as my small-animal-murder-machine got unbroken after ⠈⠳⣄⠀⠀⠀⠀ nearly two years of no catch!) -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
