On Thu, Jun 8, 2017 at 11:31 PM, Adam Borowski <kilobyte@xxxxxxxxxx> wrote: > This is a port of https://github.com/acpica/acpica/commit/eaa455ac by > Robert Moore to the kernel: > >> This call was simply wrong, and resulted in a -1 index into the operand >> stack. > > Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=120351 > Signed-off-by: Adam Borowski <kilobyte@xxxxxxxxxx> > --- > You guys fixed this in your tool months ago, but it's still unfixed in the > kernel. Let's apply that patch, then. The coding styles differ so much the > patch is hardly recognizable, but it's a direct port. Lv, any comments? > drivers/acpi/acpica/dsutils.c | 9 --------- > 1 file changed, 9 deletions(-) > > diff --git a/drivers/acpi/acpica/dsutils.c b/drivers/acpi/acpica/dsutils.c > index 406edec20de7..0dabd9b95684 100644 > --- a/drivers/acpi/acpica/dsutils.c > +++ b/drivers/acpi/acpica/dsutils.c > @@ -633,15 +633,6 @@ acpi_ds_create_operand(struct acpi_walk_state *walk_state, > > if ((op_info->flags & AML_HAS_RETVAL) || > (arg->common.flags & ACPI_PARSEOP_IN_STACK)) { > - ACPI_DEBUG_PRINT((ACPI_DB_DISPATCH, > - "Argument previously created, already stacked\n")); > - > - acpi_db_display_argument_object(walk_state-> > - operands[walk_state-> > - num_operands - > - 1], > - walk_state); > - > /* > * Use value that was already previously returned > * by the evaluation of this argument > -- > 2.11.0 -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
