On Wed, Jun 7, 2017 at 9:05 AM, Lee, Chun-Yi <joeyli.kernel@xxxxxxxxx> wrote:
> Kernel should decrements the reference count of acpi device
> when scheduling acpi hotplug work is failed, and also evaluates
> _OST to notify BIOS the failure.
> - if (hotplug_event && ACPI_SUCCESS(acpi_hotplug_schedule(adev, type)))
> - return;
> + if (hotplug_event) {
> + if (ACPI_FAILURE(acpi_hotplug_schedule(adev, type))) {
> + acpi_bus_put_acpi_device(adev);
> + goto err;
> + } else {
> + return;
> + }
> + }
Wouldn't be simpler to
- return;
+ goto err_put_device;
+ err_put_device:
+ acpi_bus_put_acpi_device(adev);
err:
--
With Best Regards,
Andy Shevchenko
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
