Hi Lv, On May 27 2017 or thereabouts, Lv Zheng wrote: > This patch adds a parameter to acpi_lid_notify_state() so that it can act > differently against BIOS notification and kernel faked events. > > Cc: <systemd-devel@xxxxxxxxxxxxxxxxxxxxx> > Cc: Benjamin Tissoires <benjamin.tissoires@xxxxxxxxxx> > Cc: Peter Hutterer <peter.hutterer@xxxxxxxxx> > Signed-off-by: Lv Zheng <lv.zheng@xxxxxxxxx> > --- Answering to this one for the entire series: last week was a mix of public holidays and PTO from me. I was only able to review this series today, so sorry for the delay. I still have a feeling this driver is far too engineered for a simple input node. There are internal states, defers, mangle of events and too many kernel parameters. I still need to get my head around it, but the more I think of it, the more I think the solution provided by Lennart in https://github.com/systemd/systemd/issues/2807 is the simplest one: when we are not sure about the state of the LID switch because _LID might be wrong, we shouldn't export a LID input node. Which means that all broken cases would be fixed by just a quirk "unreliable lid switch". Give me a day or two to get this in a better shape. Cheers, Benjamin -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
