On Wed, May 24, 2017 at 9:01 AM, Hans de Goede <hdegoede@xxxxxxxxxx> wrote: > Hi, > > On 24-05-17 01:47, Rafael J. Wysocki wrote: >> >> On Tuesday, May 23, 2017 09:58:49 PM Hans de Goede wrote: >>> >>> Hi, >> >> >> Hi, >> >>> On (some?) Cherry Trail devices the system can be woken up >>> by pressing a key on the USB attached keyboard (even on some tablets >>> with an external USB keyboard). >> >> >> So first I need to know if this is with USB wakeup properly enabled via >> sysfs >> or just because the system reacts to the first ACPI interrupt triggered >> while >> suspended. >> >> Note that USB wakeup is not enabled by default in the kernel, so if user >> space init doesn't do that, it has to be done manually. > > > I'm not doing anything specific to enable USB wakeup, but I just checked > in sysfs and yes it is enabled. I guess this gets inherited from the BIOS > and on this system the BIOS enables this by default ? That's possible. OK [cut] >>> Looking at the "ACPI / sleep: Ignore spurious SCI wakeups from >>> suspend-to-idle" commit I've added a pm_wakeup_hard_event() >>> to the int0002 driver when the GPE0A_PME_B0_STS_BIT is set and >>> with this change the fix works for 4.12-rc1 too and fixes the >>> issue with the system more or less hanging on the first wakeup >>> attempt by USB-keyboard. >> >> >> Does the USB keyboard still wake up only once? > > > No with the INT0002 driver in place I can reliable wakeup the system > with the USB keyboard every time. OK, good. Thanks, Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html