On 5/16/2017 4:58 PM, Luck, Tony wrote:
From: Tony Luck <tony.luck@xxxxxxxxx> Quoting version 6.1 of the ACPI specification. Section 18.3.1 "Boot Error Source" says: The Boot Error Region is a range of addressable memory OSPM can access during initialization to determine if an unhandled error condition occurred. System firmware must report this memory range as firmware reserved. The format of the Boot Error Region follow that of an Error Status Block, this is defined in Section 18.3.2.7. The format of the error status block is described by Table 18-342. This clarifies some points that were obfuscated in earlier versions. E.g. there is no longer a separate table to describe the format of the "Boot Error Region" (which was identical to the "Error Status Block"). Also saying "follow that of *an* Error Status Block" makes it clear that there is just one block (which can still contain multiple "Generic Error Data Entry structures"). The loop inside bert_print_all() is unnecessary (but probably harmless as the "while (remain > sizeof(struct acpi_bert_region))" loop should terminate after we skipped over the first entry. We can drop the "bert_print_all()" function and just move the four relevant lines inline in "bert_init()". Cc: Len Brown <lenb@xxxxxxxxxx> Cc: Huang Ying <ying.huang@xxxxxxxxx> Cc: Borislav Petkov <bp@xxxxxxx> Cc: Tomasz Nowicki <tomasz.nowicki@xxxxxxxxxx> Cc: Jonathan (Zhixiong) Zhang <zjzhang@xxxxxxxxxxxxxx> Cc: Tyler Baicar <tbaicar@xxxxxxxxxxxxxx> Cc: linux-acpi@xxxxxxxxxxxxxxx Reviewed-by: Borislav Petkov <bp@xxxxxxx> Signed-off-by: Tony Luck <tony.luck@xxxxxxxxx>
Tested-by: Tyler Baicar <tbaicar@xxxxxxxxxxxxxx> -- Qualcomm Datacenter Technologies, Inc. as an affiliate of Qualcomm Technologies, Inc. Qualcomm Technologies, Inc. is a member of the Code Aurora Forum, a Linux Foundation Collaborative Project. -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
