On Mon, May 15, 2017 at 9:45 AM, Benjamin Tissoires <benjamin.tissoires@xxxxxxxxxx> wrote: > On May 12 2017 or thereabouts, Rafael J. Wysocki wrote: >> On Friday, May 12, 2017 02:36:20 AM Zheng, Lv wrote: >> > Hi, >> > >> > > From: Benjamin Tissoires [mailto:benjamin.tissoires@xxxxxxxxxx] >> > > Subject: Re: [PATCH 2/2] Revert "ACPI / button: Change default behavior to lid_init_state=open" >> > > >> > > On May 11 2017 or thereabouts, Zheng, Lv wrote: >> > > > Hi, >> > > > >> > > > > From: Benjamin Tissoires [mailto:benjamin.tissoires@xxxxxxxxxx] >> > > > > Subject: [PATCH 2/2] Revert "ACPI / button: Change default behavior to lid_init_state=open" >> > > > > >> > > > > This reverts commit 77e9a4aa9de10cc1418bf9a892366988802a8025. >> > > > > >> > > > > Even if the method implementation can be buggy on some platform, >> > > > > the "open" choice is worse. It breaks docking stations basically >> > > > > and there is no way to have a user-space hwdb to fix that. >> > > > > >> > > > > On the contrary, it's rather easy in user-space to have a hwdb >> > > > > with the problematic platforms. Then, libinput (1.7.0+) can fix >> > > > > the state of the LID switch for us: you need to set the udev >> > > > > property LIBINPUT_ATTR_LID_SWITCH_RELIABILITY to 'write_open'. >> > > > > >> > > > > When libinput detects internal keyboard events, it will >> > > > > overwrite the state of the switch to open, making it reliable >> > > > > again. Given that logind only checks the LID switch value after >> > > > > a timeout, we can assume the user will use the internal keyboard >> > > > > before this timeout expires. >> > > > > >> > > > > For example, such a hwdb entry is: >> > > > > >> > > > > libinput:name:*Lid Switch*:dmi:*svnMicrosoftCorporation:pnSurface3:* >> > > > > LIBINPUT_ATTR_LID_SWITCH_RELIABILITY=write_open >> > > > > > [...] > >> >> Well, if it worked in a specific way that users depended on before the commit in >> question and now it works differently, then it does break things. >> >> Benjamin, my understanding is that this is the case, is it correct? > > That is correct. This patch I reverted introduces regression for professional > laptops that expect the LID switch to be reported accurately. And from a user's perspective, what does not work any more? Thanks, Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
