On Wed, May 10, 2017 at 6:12 PM, Benjamin Tissoires <benjamin.tissoires@xxxxxxxxxx> wrote: > The new default 'open' behavior for acpi_lid_initialize_state() is just > wrong. It breaks professional laptops with a docking station [1]. > > Booting the laptop with the LID closed is something common and now there > is no way of knowing the actual state of the LID switch at boot. Please > use a user-space solution as described in 2/2 if you really don't want to > add quirks in the kernel. > > Cheers, > Benjamin > > [1] https://bugzilla.gnome.org/show_bug.cgi?id=782380 > > Benjamin Tissoires (2): > Revert "ACPI / button: Remove lid_init_state=method mode" > Revert "ACPI / button: Change default behavior to lid_init_state=open" > > Documentation/acpi/acpi-lid.txt | 16 ++++++++++++---- > drivers/acpi/button.c | 11 ++++++++++- > 2 files changed, 22 insertions(+), 5 deletions(-) Well, have you seen the recent series (http://marc.info/?l=linux-acpi&m=149431335204701&w=2 and the following) from Lv? He evidently agrees with you that "ACPI / button: Remove lid_init_state=method mode" should be reverted, but then there are differences. Can you please have a look at that and let me know what's wrong with it in your view? I'd like to have a full picture if poss. Thanks, Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
