On 05/10/2017 12:24 PM, Lorenzo Pieralisi wrote:
On Tue, May 09, 2017 at 07:20:48PM +0300, Andy Shevchenko wrote:
It means either ID is not added to drivers/acpi/acpi_apd.c or
Just one question, did you look at all into above driver?
I suppose it missed ID and properties for the device.
I looked into it yes. I have also looked at ACPI tables and they
contain the SSCN and FMCN methods and AFAIK the set-up was working
fine before the commit in $SUBJECT - AMD guys - please correct me
if I am wrong, I found this thread which explains things a bit:
http://lists.infradead.org/pipermail/linux-arm-kernel/2015-December/395983.html
If we have to patch drivers/acpi/acpi_apd.c to restore the previous
behaviour that's fine by me but this is a regression nonetheless unless
someone explains to me why the current firmware set-up (with SSCN and
FMCN) is unreliable/deprecated, it is not clear to me at all and it
may affect other platforms too.
I guess best would be to fix the i2c_dw_init(). Maybe by moving timing
parameters settings out to another function, do setting only for
selected speed and calculate only once in case parameters are not set.
I don't think timing parameters for standard or fast speeds are not
needed unless operating at those speeds but have to check that first. At
least that's what we are doing for high speed.
--
Jarkko
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
