On Fri, 2017-04-28 at 15:59 -0700, Dan Williams wrote: > ...but again, hex_dump_dbg() implies to me dev_dbg() behavior, i.e. > that the hexdump happens in the KERN_DEBUG case I think you are confusing KERN_DEBUG, a logging level, with a preprocessor #define of DEBUG. > which I don't want. I > want the call to be compiled out completely when it can't be > enabled/disabled dynamically. dev_dbg is compiled away completely when DEBUG is not defined and when CONFIG_DYNAMIC_DEBUG is not defined. This hex_dump facility should behave the same way. > I think we do need a hex_dump_dbg(), but that does not eliminate the > utility of / need for dynamic_hex_dump(). dynamic_hex_dump should only exist when CONFIG_DYNAMIC_DEBUG is enabled and should otherwise be invisible to driver code. -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
