RE: [PATCH v2 1/4] ACPICA: Tables: Fix regression introduced by a too early mechanism enabling

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



The revision looks wrong.
It's actually v3 from my side.
Please drop this.
I'll re-format the series.
Sorry for the noise.

Thanks
Lv

> From: Zheng, Lv
> Sent: Friday, April 28, 2017 1:27 PM
> Subject: [PATCH v2 1/4] ACPICA: Tables: Fix regression introduced by a too early mechanism enabling
> 
> In the Linux kernel side, acpi_get_table() clones haven't been fully
> balanced by acpi_put_table() invocations. In ACPICA side, due to the design
> change, there are also unbalanced acpi_get_table_by_index() invocations
> requiring special care.
> 
> So it is not a good timing to report acpi_get_table() counting errors. The
> strict balanced validation count check should only be enabled after
> confirming that all invocations are safe and compliant to their designed
> purposes.
> 
> Thus this patch removes the fatal error along with the error report to
> fix this issue. Reported by Dan Williams, fixed by Lv Zheng.
> 
> Fixes: 174cc7187e6f ("ACPICA: Tables: Back port acpi_get_table_with_size() and
> early_acpi_os_unmap_memory() from Linux kernel")
> Cc: Dan Williams <dan.j.williams@xxxxxxxxx>
> Reported-by: Anush Seetharaman <anush.seetharaman@xxxxxxxxx>
> Reported-by: Dan Williams <dan.j.williams@xxxxxxxxx>
> Signed-off-by: Lv Zheng <lv.zheng@xxxxxxxxx>
> ---
>  drivers/acpi/acpica/tbutils.c | 4 ----
>  1 file changed, 4 deletions(-)
> 
> diff --git a/drivers/acpi/acpica/tbutils.c b/drivers/acpi/acpica/tbutils.c
> index 5a968a7..7abe665 100644
> --- a/drivers/acpi/acpica/tbutils.c
> +++ b/drivers/acpi/acpica/tbutils.c
> @@ -418,11 +418,7 @@ acpi_tb_get_table(struct acpi_table_desc *table_desc,
> 
>  	table_desc->validation_count++;
>  	if (table_desc->validation_count == 0) {
> -		ACPI_ERROR((AE_INFO,
> -			    "Table %p, Validation count is zero after increment\n",
> -			    table_desc));
>  		table_desc->validation_count--;
> -		return_ACPI_STATUS(AE_LIMIT);
>  	}
> 
>  	*out_table = table_desc->pointer;
> --
> 2.7.4

--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux