On Tue, Apr 25, 2017 at 6:49 PM, Lv Zheng <lv.zheng@xxxxxxxxx> wrote: > In the Linux kernel side, acpi_get_table() hasn't been fully balanced by > acpi_put_table() invocations. So it is not a good timing to report errors. > The strict balanced validation count check should only be enabled after > confirming that all kernel side invocations are safe. We've been living with this bug for 7 years, let's just go fix all acpi_get_table() invocations to make sure they have a corresponding acpi_put_table(). > > Thus this patch removes the fatal error but leaves the error report to > indicate the leak so that developers can notice the required engineering > change. Reported by Dan Williams, fixed by Lv Zheng. > > Reported-by: Dan Williams <dan.j.williams@xxxxxxxxx> > Signed-off-by: Lv Zheng <lv.zheng@xxxxxxxxx> > --- > drivers/acpi/acpica/tbutils.c | 1 - > 1 file changed, 1 deletion(-) > > diff --git a/drivers/acpi/acpica/tbutils.c b/drivers/acpi/acpica/tbutils.c > index 5a968a7..9e7d95cf 100644 > --- a/drivers/acpi/acpica/tbutils.c > +++ b/drivers/acpi/acpica/tbutils.c > @@ -422,7 +422,6 @@ acpi_tb_get_table(struct acpi_table_desc *table_desc, > "Table %p, Validation count is zero after increment\n", > table_desc)); > table_desc->validation_count--; > - return_ACPI_STATUS(AE_LIMIT); If you want to leave the error report turn it into a WARN_ON_ONCE() so it doesn't keep triggering, but I'd rather we just focus on the missing acpi_put_table() calls. -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
