On Thu, Apr 20, 2017 at 10:19 AM, Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx> wrote: > On Wed, 2017-04-19 at 22:18 +0200, Rafael J. Wysocki wrote: >> On Wed, Apr 19, 2017 at 3:07 PM, Hans de Goede <hdegoede@xxxxxxxxxx> >> wrote: >> > The intel_pmic_xpower code provides an OPRegion handler, which must >> > be >> > available before other drivers using it are loaded, which can only >> > be >> > ensured if both the mfd and opregion drivers are built in, which is >> > why >> > the Kconfig option for intel_pmic_xpower is a bool. >> > >> > The use of IIO is causing trouble for generic distro configs here as >> > distros will typically want to build IIO drivers as modules and >> > there >> > really is no reason to use IIO here. The reading of the ADC value is >> > a >> > single regmap_bulk_read, which is already protected against races by >> > the regmap-lock. >> > >> > This commit removes the use of IIO, allowing distros to enable the >> > driver without needing to built IIO in and also actually simplifies >> > the code. >> > >> > Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx> >> >> Andy, Srinivas, any concerns? > > I would prefer to have this magic shifts in a common header between > drivers, but I'm not insisting (I admit it might take much more work for > no clear benefit, except keeping ADC bits in one place). > > So, I'm fine with this change. OK I'm going to apply the series then. Thanks, Rafael -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
