Re: [PATCH v2 1/8] v4l: flash led class: Use fwnode_handle instead of device_node in init

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



Hi Sakari,

[auto build test ERROR on linuxtv-media/master]
[also build test ERROR on v4.11-rc5 next-20170406]
[if your patch is applied to the wrong git tree, please drop us a note to help improve the system]

url:    https://github.com/0day-ci/linux/commits/Sakari-Ailus/v4l-flash-led-class-Use-fwnode_handle-instead-of-device_node-in-init/20170407-133451
base:   git://linuxtv.org/media_tree.git master
config: i386-randconfig-x013-201714 (attached as .config)
compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901
reproduce:
        # save the attached .config to linux build tree
        make ARCH=i386 

All error/warnings (new ones prefixed by >>):

   drivers/media//v4l2-core/v4l2-flash-led-class.c: In function 'v4l2_flash_init':
>> drivers/media//v4l2-core/v4l2-flash-led-class.c:642:4: error: 'struct v4l2_subdev' has no member named 'fwnode'; did you mean 'of_node'?
     sd->fwnode = fwn ? fwn : dev_fwnode(led_cdev->dev);
       ^~
>> drivers/media//v4l2-core/v4l2-flash-led-class.c:642:27: error: implicit declaration of function 'dev_fwnode' [-Werror=implicit-function-declaration]
     sd->fwnode = fwn ? fwn : dev_fwnode(led_cdev->dev);
                              ^~~~~~~~~~
>> drivers/media//v4l2-core/v4l2-flash-led-class.c:642:25: warning: pointer/integer type mismatch in conditional expression
     sd->fwnode = fwn ? fwn : dev_fwnode(led_cdev->dev);
                            ^
>> drivers/media//v4l2-core/v4l2-flash-led-class.c:658:2: error: implicit declaration of function 'fwnode_handle_get' [-Werror=implicit-function-declaration]
     fwnode_handle_get(sd->fwnode);
     ^~~~~~~~~~~~~~~~~
   drivers/media//v4l2-core/v4l2-flash-led-class.c:658:22: error: 'struct v4l2_subdev' has no member named 'fwnode'; did you mean 'of_node'?
     fwnode_handle_get(sd->fwnode);
                         ^~
   drivers/media//v4l2-core/v4l2-flash-led-class.c:667:22: error: 'struct v4l2_subdev' has no member named 'fwnode'; did you mean 'of_node'?
     fwnode_handle_put(sd->fwnode);
                         ^~
   drivers/media//v4l2-core/v4l2-flash-led-class.c: In function 'v4l2_flash_release':
   drivers/media//v4l2-core/v4l2-flash-led-class.c:687:22: error: 'struct v4l2_subdev' has no member named 'fwnode'; did you mean 'of_node'?
     fwnode_handle_put(sd->fwnode);
                         ^~
   cc1: some warnings being treated as errors

vim +642 drivers/media//v4l2-core/v4l2-flash-led-class.c

   636	
   637		sd = &v4l2_flash->sd;
   638		v4l2_flash->fled_cdev = fled_cdev;
   639		v4l2_flash->iled_cdev = iled_cdev;
   640		v4l2_flash->ops = ops;
   641		sd->dev = dev;
 > 642		sd->fwnode = fwn ? fwn : dev_fwnode(led_cdev->dev);
   643		v4l2_subdev_init(sd, &v4l2_flash_subdev_ops);
   644		sd->internal_ops = &v4l2_flash_subdev_internal_ops;
   645		sd->flags |= V4L2_SUBDEV_FL_HAS_DEVNODE;
   646		strlcpy(sd->name, config->dev_name, sizeof(sd->name));
   647	
   648		ret = media_entity_pads_init(&sd->entity, 0, NULL);
   649		if (ret < 0)
   650			return ERR_PTR(ret);
   651	
   652		sd->entity.function = MEDIA_ENT_F_FLASH;
   653	
   654		ret = v4l2_flash_init_controls(v4l2_flash, config);
   655		if (ret < 0)
   656			goto err_init_controls;
   657	
 > 658		fwnode_handle_get(sd->fwnode);
   659	
   660		ret = v4l2_async_register_subdev(sd);
   661		if (ret < 0)

---
0-DAY kernel test infrastructure                Open Source Technology Center
https://lists.01.org/pipermail/kbuild-all                   Intel Corporation

Attachment: .config.gz
Description: application/gzip


[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux