On Wed, Mar 15, 2017 at 03:23:41PM +0100, Rafael J. Wysocki wrote: > On Wed, Mar 15, 2017 at 3:19 PM, Sakari Ailus <sakari.ailus@xxxxxx> wrote: > > On Mon, Mar 13, 2017 at 11:27:40PM +0100, Rafael J. Wysocki wrote: > >> On Monday, March 06, 2017 05:42:46 PM Sakari Ailus wrote: > >> > Hi, > >> > > >> > This set moves firmware specific implementations of the device / fwnode > >> > property API to locations that are specific to firmware implementation, > >> > still leaving property set (which isn't really firmware) implementation in > >> > drivers/base/property.c. > >> > > >> > The set depends on the ACPI graph support v4 patches I posted a moment > >> > ago. > >> > > >> > The patches may be found with dependencies here: > >> > > >> > <URL:https://git.linuxtv.org/sailus/media_tree.git/log/?h=acpi-graph-cleaned> > >> > > >> > since v1: > >> > > >> > - Move the three bugfixes in front of the set into a separate patchset. > >> > There are no dependencies to those from the rest of the patches. > >> > > >> > - Rebase on current ACPI graph support patches (themselves on PM tree > >> > 4.11-rc1 merge). > >> > >> To me, all material from patches [1-11/17] can easily go into one patch which > >> would also help to review it quite a bit. > >> > >> Analogously, all material in patches [12-16/17] can go into one patch too. > >> > >> The split as is appears quite artificial, honestly. > > > > I believe it's easier to review the way it is. Each patch is simple and it's > > easy to see where a particular piece of code is moved. I'm happy to fold > > them, too, but I'd prefer keep "[PATCH v2 07/17] device property: Read > > strings using string array reading functions" separate, as it changes the > > implementation of reading single strings. > > > > How about that? > > That's fine too. I kept the last patch (device property: Implement fwnode_get_next_parent() using fwnode interface) separate, too, as I noticed it is really separate from moving the FW type specific parts behind an ops struct. The details are on the cover page of v3 of the set. -- Sakari Ailus e-mail: sakari.ailus@xxxxxx XMPP: sailus@xxxxxxxxxxxxxx -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
