Hi, Hans > From: Hans de Goede [mailto:hdegoede@xxxxxxxxxx] > Subject: Re: [PATCH] ACPICA: Log Exceptions and Errors as warning while loading extra tables > > Hi, > > On 14-03-17 09:15, Zheng, Lv wrote: > > Hi, Hans > > > >> From: Hans de Goede [mailto:hdegoede@xxxxxxxxxx] > >> Subject: Re: [PATCH] ACPICA: Log Exceptions and Errors as warning while loading extra tables > >> > >> Hi, > >> > >> On 13-03-17 10:52, Zheng, Lv wrote: > >>> Hi, Hans > >>> > >>> For log level issue, is this fix useful for you? > >>> https://github.com/acpica/acpica/pull/121/commits/a505d3942 > >> > >> That fixes reloading already loaded tables, the problem I'm > >> getting errors about its loading a different table with identical > >> contents. > >> > >> I will look into your suggestion to do something similar to > >> AcpiTbInstallStandardTable using AcpiTbCompareTables for the > >> SSDT tables. I will send a new patch when I can make some time > >> to look into this. > > > > I just completed a prototype here: > > https://github.com/acpica/acpica/pull/121 > > > > I guess the original "duplicate table check" couldn't cover static SSDTs. > > Actually the duplicate table check should be a sanity check of table load. > > And for table install, we should have a different sanity check like: > > https://github.com/acpica/acpica/pull/121/commits/6e825cae5e5 > > I'm not sure if this is what you want. > > This checks for having 2 table_descriptors pointing to the same table > (address in memory). But in my case there are 2 identical copies of > the table at 2 different addresses in memory, so this won't work. > > After looking at this a bit myself, I think fixing this is actually > quite easy (now that you've pointed me to acpi_tb_install_standard_table() > > I've come up with the attached patch to fix this. I will give this a test > spin and then submit it officially (assuming it works). In the pull request, there are 4 fixes: 1. add table install sanity check by detecting duplicates with table address and table type. 2. extend table load sanity check to LoadTable opcode. 3. extend table load sanity check to static loaded SSDTs - I think this should be able to cover your case. 4. if install/load sanity checks detect duplicate tables, they return AE_ALREADY_EXISTS and the error is silently discarded. That's the whole story for the pull request. I think you only checked one of them. Thanks and best regards Lv -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
