Hi,
On 02-03-17 02:59, Zheng, Lv wrote:
Hi,
From: Hans de Goede [mailto:hdegoede@xxxxxxxxxx]
Subject: Re: [PATCH] ACPICA: Detect duplicate SSDT tables
Hi,
On 01-03-17 04:21, Zheng, Lv wrote:
Hi,
From: Hans de Goede [mailto:hdegoede@xxxxxxxxxx]
Subject: Re: [PATCH] ACPICA: Detect duplicate SSDT tables
Hi,
On 28-02-17 06:19, Zheng, Lv wrote:
Hi,
From: Hans de Goede [mailto:hdegoede@xxxxxxxxxx]
Subject: [PATCH] ACPICA: Detect duplicate SSDT tables
Some machines have the exact (byte for byte) same SSDT tables multiple
times in the root_table_list.
<snip>
Detect this and silently skip the duplicates
rather then printing a scary looking set of errors.
<snip>
Signed-off-by: Hans de Goede <hdegoede@xxxxxxxxxx>
---
drivers/acpi/acpica/tbxfload.c | 41 ++++++++++++++++++++++++++++++++++++++++-
1 file changed, 40 insertions(+), 1 deletion(-)
diff --git a/drivers/acpi/acpica/tbxfload.c b/drivers/acpi/acpica/tbxfload.c
index 82019c0..1971cd7 100644
--- a/drivers/acpi/acpica/tbxfload.c
+++ b/drivers/acpi/acpica/tbxfload.c
@@ -125,6 +125,44 @@ ACPI_EXPORT_SYMBOL_INIT(acpi_load_tables)
/*******************************************************************************
*
+ * FUNCTION: acpi_tb_find_duplicate_ssdt
+ *
+ * PARAMETERS: table - validated acpi_table_desc of table to check
+ * index - index of table to find a duplicate of
+ *
+ * RETURN: TRUE if a duplicate is found, FALSE if not
+ *
+ * DESCRIPTION: Private helper function for acpi_tb_load_namespace to
+ * avoid trying to load duplicate ssdt tables
+ *
+ ******************************************************************************/
+static u8 acpi_tb_find_duplicate_ssdt(struct acpi_table_desc *table, u32 index)
If you really want to add this.
My suggestion is:
Invoke this function in acpi_tb_verify_temp_table().
This is the function we use to verify if a table is OK.
Otherwise it won't be installed to the global table list.
And the name should contain "aml_table" or "aml" rather than "ssdt" according to your check below.
Ok, when I've some time I will do a new version moving the functionality
to acpi_tb_verify_temp_table(). I will post a v2 with this change when
it is ready. I will also just compare the headers then as suggested in
other replies in this thread.
Regards,
Hans
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
