On Mon, 20 Feb 2017, Dou Liyang wrote: Please make your subject line short and a precise summary phrase, not an overlong sentence. > After we revert the the mapping of "cpuid <-> nodeid" fixed at the > booting time. and do it at the hot-plug time. we should also do the > verification of duplicate proc_id at the time. The revert is completely irrelevant to this change, really. The reference is just confusing. > The patch rename the verfication function and move it to > drivers/acpi::acpi_processor_get_info. See previous mails .... Let me give you another changelog example: Subject: acpi/processor: Check for duplicate processor ids at hotplug time The check for duplicate processor ids happens at boot time based on the ACPI table contents, but the final sanity checks for a processor happen at hotplug time. At hotplug time, where the physical information is available, which might differ from the ACPI table information, a check for duplicate processor ids is missing. Add it to the hotplug checks and rename the function so it better reflects its purpose. Hmm? > > -bool __init acpi_processor_validate_proc_id(int proc_id) > +bool duplicate_processor_id(int proc_id) Please keep the acpi_ prefix. acpi_duplicate_processor_id(). Thanks, tglx -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
