On Tue, 2017-02-28 at 12:18 +0100, Hans de Goede wrote:
> Hi,
>
> Thnak you for the review.
>
> On 27-02-17 22:50, Andy Shevchenko wrote:
> > On Mon, Feb 27, 2017 at 10:26 PM, Hans de Goede <hdegoede@xxxxxxxxxx
> > > wrote:
> > > Add opregion driver for Intel CHT WhiskeyCove PMIC, based on
> > > various
> > > non upstreamed CHT WhiskeyCove PMIC patches. This does not include
> > > support for the Thermal opregion (DPTF) due to lacking
> > > documentation.
> >
> > Couple of nitpicks.
> >
> > > @@ -0,0 +1,232 @@
> > > +/*
> > > + * intel_pmic_chtwc.c - Intel CHT Whiskey Cove PMIC operation
> > > region driver
> >
> > I would remove file name. You never know if it's going to be renamed
> > or not.
> >
> > > +static int intel_cht_wc_pmic_update_power(struct regmap *regmap,
> > > int reg,
> > > + int bit, bool on)
> > > +{
> > > + u8 mask = bit;
> > > +
> > > + return regmap_update_bits(regmap, reg, mask, on ? 1 : 0);
> >
> > Hmm... Just leave one line?
>
> Both fixed. I will send a new version together with a new version
> of the Intel CHT WhiskeyCove PMIC mfd driver.
Please add my
Reviewed-by: Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
--
Andy Shevchenko <andriy.shevchenko@xxxxxxxxxxxxxxx>
Intel Finland Oy
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at http://vger.kernel.org/majordomo-info.html
