If we don't absolutely need to make any changes (if it ain't broke), then we should not try to fix it. Yes, there are some strange things in the ACPICA headers. Making the ACPICA code compile with many different C compilers for many different operating systems has been an extremely challenging and difficult project. Even the smallest change has the potential to cause problems elsewhere. > -----Original Message----- > From: Zheng, Lv > Sent: Wednesday, November 16, 2016 9:55 PM > To: Bart Van Assche; Moore, Robert; Rafael J. Wysocki > Cc: Rafael J. Wysocki; Len Brown; linux-acpi@xxxxxxxxxxxxxxx > Subject: RE: [PATCH] acpi: Use NULL from <linux/stddef.h> > > Hi, > > > From: Bart Van Assche [mailto:bart.vanassche@xxxxxxxxxxx] > > Subject: Re: [PATCH] acpi: Use NULL from <linux/stddef.h> > > > > On 11/16/2016 09:08 AM, Moore, Robert wrote: > > > What is the point of these changes? > > > > What's the point of redefining NULL? What's the point of casting a > > void pointer to void *? > > Maybe you only need to put the following line into aclinux.h: > +#include <linux/stddef.h> /* NULL */ > > And leave ACPICA protection there: > > #ifndef NULL > ... > #endif > > For changing (void *) NULL to NULL, sounds minor. > It can be there for other OSPMs. > > Thanks > Lv ��.n��������+%������w��{.n�����{�����ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f
