Hi, > From: Zheng, Lv > Subject: RE: Fix in ACPICA tools broke cross compilation of tools/power/acpi > > Hi, Andy > > > From: Andy Shevchenko [mailto:andy.shevchenko@xxxxxxxxx] > > Subject: Re: Fix in ACPICA tools broke cross compilation of tools/power/acpi > > > > On Tue, Nov 15, 2016 at 5:01 PM, Andy Shevchenko > > <andy.shevchenko@xxxxxxxxx> wrote: > > > > > The below + several runs (need to serialize makefile, by default it > > > races install vs. build) helped eventually. > > > > Isn't better just to revert patch I mention and continue from working case? > > It's not possible to revert that patch. > It contains correct header inclusion cleanups. > While this case is in fact a special case, bugs in tools/Makefile are triggered (about OUT/SRC). > > OTOH, this case is actually not a very useful case. > We can see many tools build broken for cross-compilers, and tools/power/acpi is not the only one. > We are just to improve it. We can clearly see that: 1. the commit is correct, it can cleanly sort the inclusion orders. 2. tools/power/acpi build is still working, just have issues with cross toolchains. 3. the strict inclusion order (signal.h) itself is a bug - because toolchain issue and ACPICA trick. 4. tools/power/acpi makefiles are not handling OUT/SRC correctly. So why do we need to revert correct thing to support a buggy behavior? We are just finding a way to make tools/power/acpi build more robust for such a buggy behavior. Thanks Lv ��.n��������+%������w��{.n�����{�����ܨ}���Ơz�j:+v�����w����ޙ��&�)ߡ�a����z�ޗ���ݢj��w�f
