> -----Original Message----- > From: kbuild test robot [mailto:lkp@xxxxxxxxx] > Sent: Thursday, November 10, 2016 4:15 PM > To: Limonciello, Mario <Mario_Limonciello@xxxxxxxx> > Cc: kbuild-all@xxxxxx; linux-acpi@xxxxxxxxxxxxxxx; Len Brown > <lenb@xxxxxxxxxx>; Rafael J . Wysocki <rjw@xxxxxxxxxxxxx>; Andy > Lutomirski <luto@xxxxxxxxxx>; Limonciello, Mario > <Mario_Limonciello@xxxxxxxx> > Subject: Re: [PATCH] acpi/sleep: Use the FADT to prefer Suspend-to-Idle > instead of S3 > > Hi Mario, > > [auto build test ERROR on pm/linux-next] > [also build test ERROR on v4.9-rc4 next-20161110] > [if your patch is applied to the wrong git tree, please drop us a note to help > improve the system] > > url: https://github.com/0day-ci/linux/commits/Mario-Limonciello/acpi- > sleep-Use-the-FADT-to-prefer-Suspend-to-Idle-instead-of-S3/20161111- > 055555 > base: https://git.kernel.org/pub/scm/linux/kernel/git/rafael/linux-pm.git > linux-next > config: i386-randconfig-x006-201645 (attached as .config) > compiler: gcc-6 (Debian 6.2.0-3) 6.2.0 20160901 > reproduce: > # save the attached .config to linux build tree > make ARCH=i386 > > All error/warnings (new ones prefixed by >>): > > In file included from include/linux/linkage.h:4:0, > from include/linux/kernel.h:6, > from include/linux/delay.h:10, > from drivers/acpi/sleep.c:13: > drivers/acpi/sleep.c: In function 'acpi_sleep_init': > >> drivers/acpi/sleep.c:917:6: error: implicit declaration of function > 'suspend_to_idle_preferred' [-Werror=implicit-function-declaration] > if (suspend_to_idle_preferred()) { > ^ > include/linux/compiler.h:149:30: note: in definition of macro '__trace_if' > if (__builtin_constant_p(!!(cond)) ? !!(cond) : \ > ^~~~ > >> drivers/acpi/sleep.c:917:2: note: in expansion of macro 'if' > if (suspend_to_idle_preferred()) { > ^~ > Cyclomatic Complexity 1 > arch/x86/include/asm/paravirt.h:arch_local_irq_disable > Cyclomatic Complexity 1 drivers/acpi/sleep.c:acpi_sleep_dmi_check > Cyclomatic Complexity 1 drivers/acpi/sleep.c:acpi_sleep_suspend_setup > Cyclomatic Complexity 1 drivers/acpi/sleep.c:acpi_sleep_syscore_init > Cyclomatic Complexity 1 drivers/acpi/sleep.c:acpi_sleep_hibernate_setup > Cyclomatic Complexity 9 drivers/acpi/sleep.c:acpi_sleep_tts_switch > Cyclomatic Complexity 9 drivers/acpi/sleep.c:acpi_sleep_pts_switch > Cyclomatic Complexity 1 drivers/acpi/sleep.c:sleep_notify_reboot > Cyclomatic Complexity 1 drivers/acpi/sleep.c:acpi_power_off > Cyclomatic Complexity 1 drivers/acpi/sleep.c:acpi_sleep_prepare > Cyclomatic Complexity 1 drivers/acpi/sleep.c:acpi_power_off_prepare > Cyclomatic Complexity 5 drivers/acpi/sleep.c:acpi_sleep_state_supported > Cyclomatic Complexity 6 drivers/acpi/sleep.c:acpi_sleep_init > cc1: some warnings being treated as errors > > vim +/suspend_to_idle_preferred +917 drivers/acpi/sleep.c > > 911 pm_power_off_prepare = acpi_power_off_prepare; > 912 pm_power_off = acpi_power_off; > 913 } else { > 914 acpi_no_s5 = true; > 915 } > 916 > > 917 if (suspend_to_idle_preferred()) { > 918 sleep_states[ACPI_STATE_S3] = 0; > 919 sleep_states[ACPI_STATE_S1] = 0; > 920 } > > --- > 0-DAY kernel test infrastructure Open Source Technology Center > https://lists.01.org/pipermail/kbuild-all Intel Corporation In v2 I'll resubmit with the test moved into acpi_sleep_suspend_setup(void) so that this works properly even if CONFIG_ACPI_SLEEP isn't enabled. I'll look for any other comments however about this approach before I submit v2. Thanks, -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html