On Thu, 03 Nov 2016, Dave Lambley wrote: > On 2 November 2016 at 23:26, Henrique de Moraes Holschuh <hmh@xxxxxxxxxx> wrote: > > > > On Wed, 02 Nov 2016, Dave Lambley wrote: > > > -static int acpi_battery_get_info(struct acpi_battery *battery) > > > + > > > +int extract_battery_info(const int use_bix, > > > + struct acpi_battery *battery, > > > + const struct acpi_buffer *buffer) > > > > Shouldn't extract_battery_info() be static as well? > > I do not believe it needs to be exported. It is a new function only > used inside battery.c. Indeed. Therefore, it really should be made static. Please fix that on the next version of your patch... -- Henrique Holschuh -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
