Re: [PATCH v2 3/3] libnvdimm: clear the internal poison_list when clearing badblocks

[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

 



On Fri, Sep 30, 2016 at 1:10 PM, Vishal Verma <vishal.l.verma@xxxxxxxxx> wrote:
> nvdimm_clear_poison cleared the user-visible badblocks, and sent
> commands to the NVDIMM to clear the areas marked as 'poison', but it
> neglected to clear the same areas from the internal poison_list which is
> used to marshal ARS results before sorting them by namespace. As a
> result, once on-demand ARS functionality was added:
>
> 37b137f nfit, libnvdimm: allow an ARS scrub to be triggered on demand
>
> A scrub triggered from either sysfs or an MCE was found to be adding
> stale entries that had been cleared from gendisk->badblocks, but were
> still present in nvdimm_bus->poison_list.
>
> This adds the missing step of clearing poison_list entries when clearing
> poison, so that it is in sync with badblocks.
>
> Fixes: 37b137f nfit, libnvdimm: allow an ARS scrub to be triggered on demand
> Cc: Dan Williams <dan.j.williams@xxxxxxxxx>
> Signed-off-by: Vishal Verma <vishal.l.verma@xxxxxxxxx>

Looks good, when you resend the other patches amend this changelog to
also say that the cleared errors come back if you disable and
re-enable a namespace.
--
To unsubscribe from this list: send the line "unsubscribe linux-acpi" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html



[Index of Archives]     [Linux IBM ACPI]     [Linux Power Management]     [Linux Kernel]     [Linux Laptop]     [Kernel Newbies]     [Share Photos]     [Security]     [Netfilter]     [Bugtraq]     [Yosemite News]     [MIPS Linux]     [ARM Linux]     [Linux Security]     [Linux RAID]     [Samba]     [Video 4 Linux]     [Device Mapper]     [Linux Resources]

  Powered by Linux