Hi Hoan, On 8/30/2016 12:20 PM, Hoan Tran wrote: > On Thu, Jul 21, 2016 at 2:07 PM, Hoan Tran <hotran@xxxxxxx> wrote: >> For PCC mailbox with interrupt flag, CPPC should call mbox_chan_txdone() >> function to notify the mailbox framework about TX completion. >> >> Signed-off-by: Hoan Tran <hotran@xxxxxxx> >> --- >> This patch is tested on top and depends on patch[1]: >> [1] http://www.spinics.net/lists/linux-acpi/msg66041.html >> - [PATCH v3] mailbox: pcc: Support HW-Reduced Communication Subspace type 2 >> >> drivers/acpi/cppc_acpi.c | 6 +++++- >> 1 file changed, 5 insertions(+), 1 deletion(-) >> >> diff --git a/drivers/acpi/cppc_acpi.c b/drivers/acpi/cppc_acpi.c >> index 2e98173..19606aa 100644 >> --- a/drivers/acpi/cppc_acpi.c >> +++ b/drivers/acpi/cppc_acpi.c >> @@ -191,7 +191,11 @@ static int send_pcc_cmd(u16 cmd) >> last_cmd_cmpl_time = ktime_get(); >> } >> >> - mbox_client_txdone(pcc_channel, ret); >> + if (pcc_channel->mbox->txdone_irq) >> + mbox_chan_txdone(pcc_channel, ret); >> + else >> + mbox_client_txdone(pcc_channel, ret); >> + Firstly, sorry for the delay. I was wondering if we should call txdone in PCC interrupt routine as done in some of the mailbox drivers. But then, since we need to support both polling and interrupt, I suppose this makes sense. Reviewed-by: Prashanth Prakash <pprakash@xxxxxxxxxxxxxx> Thanks, Prashanth >> return ret; >> } >> >> -- >> 1.9.1 >> > Any feedbacks. > > Thanks > Hoan -- To unsubscribe from this list: send the line "unsubscribe linux-acpi" in the body of a message to majordomo@xxxxxxxxxxxxxxx More majordomo info at http://vger.kernel.org/majordomo-info.html
